KingContaria / seedqueue

Minecraft mod that generates multiple worlds concurrently and lets players reset them on an ingame wall screen.
MIT License
30 stars 17 forks source link

Feature - "Visible Previews Per Second" Benchmark #41

Open joe-ldp opened 1 month ago

joe-ldp commented 1 month ago

This would require a certain world generated percentage before resetting, thus providing a more realistic benchmark as no one resets previews within 1 frame

KingContaria commented 1 month ago

Instead, a minimum percentage of rendered chunks could also be used. This would probably be more accurate however it might have some inaccuracies with WorldPreview: WorldPreview sends only sends chunks within Chunk Distance and within the view frustum, however additionally it also sends empty chunks for culled chunks that are neighbouring chunks that weren't culled for biome data and entities that are in those chunks but still visible because their render bounding box is outside the chunk bounding box. These chunks shouldn't be build by Sodium, but it should be checked that they aren't and additionally I'm unsure off the top of my head if chunks that are outside Chunk Distance also send empty chunks. Seems like an interesting issue for contributors who are interested in learning about WorldPreviews packet system and SeedQueues wall preview rendering!