search

KingContaria / seedqueue

Minecraft mod that generates multiple worlds concurrently and lets players reset them on an ingame wall screen.
MIT License
32 stars 18 forks source link

Logging of information about the current system #51

Closed Crystal15118 closed 3 months ago

Crystal15118 commented 3 months ago

Information about the system is printed to the log file when client is initialized.

maskersss commented 3 months ago

Runtime#totalMemory returns the amount of RAM used at that very moment, which isn't useful and Runtime#freeMemory also isn't helpful

is it not? would something like "current amount of free ram + current amount of ram used by minecraft" not be a good way to judge how much ram you can allocate? obviously there's going to be some rng in how much ram everything is using, but it still sounds useful to me the only issue i can maybe see with it is if OS is paging some memory, idk if it's possible to figure it out, but there could be more issues i haven't thought of

KingContaria commented 3 months ago

Runtime#maxMemory gives the amount of allocated ram

maskersss commented 3 months ago

oh i think i misunderstood what this means, is Runtime#totalMemory / Runtime#freeMemory referring to the amount of total/free memory used by the java process? i thought it was about ram on your pc in general mb in this case, still, would it be useful/possible/has it been implemented to check the amount of free ram on your pc (accounting for obs and stuff)?

KingContaria commented 3 months ago

It could be helpful in some cases but misleading in others because from reading the log we can't know if they started OBS before or after Minecraft

tildejustin commented 3 months ago

could you add a system property to disable this? I didn't like sleepbg config printing so I'd like to be able to turn this off as well and be able to read my logs easier.

Crystal15118 commented 3 months ago

could you add a system property to disable this? I didn't like sleepbg config printing so I'd like to be able to turn this off as well and be able to read my logs easier.

i can but it will likely take much more time and i don't think it would be as worth it as the effort but let's see what others say as well

KingContaria commented 3 months ago

I'm not opposed to a system property