reset password dialog error when no email is configured or an error has occured

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Disable internet connection/fill in a faulty smtp config
2. Click on forgotten password
3. Fill in a correct email address

What is the expected output? What do you see instead?
Expected output is that een error is occurred, contact your Administrator.
A dialog comes up and displays: (Header)Failure (Body) [ object, object].

What version of the add-on are you using? Please provide version of the
downloaded package, or Subversion revision number.
version 2.0 for Alfresco 4.0x

What version of Alfresco are you using? On what application server?
4.0.2 Enterprise on tomcat with MySQL

What web browser are you using? Please supply browser name and version.
Firefox 15.0

Please provide any additional information below.
In the Alfresco logs I see clearly that it couldn't get any connection with the 
SMTP server and following:

at 
org.mozilla.javascript.gen.c20._c5(jar:file:/opt/alfresco-4.0.2/tomcat/shared/li
b/reset-password-dialog-2.0.jar!/alfresco/templates/webscripts/org/sharextras/sl
ingshot/reset-user-password.post.json.js:51)

Original issue reported on code.google.com by tahirjuv...@gmail.com on 3 Sep 2012 at 2:44

[GoogleCodeExporter]

Original comment by will.abson on 11 Sep 2012 at 11:17

• Changed state: Accepted
• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

I could not reproduce this issue on the latest Community release (4.2.a) but 
Enterprise 4.0.2 did suffer the problem.

The cause is that the web script framework in that version does not properly 
catch the exception that is thrown and therefore information on the problem 
that has occurred is not returned in the JSON response (in fact the response 
format is changed to HTML and contains no useful information).

Adding a custom failure handler to the dialog seems to fix the problem, so that 
in the event of no failure info being returned, a generic message is now 
displayed.

Original comment by will.abson on 17 Oct 2012 at 5:34

• Changed state: Started

[GoogleCodeExporter]

Fixed in r1315 / v2.0.1

Original comment by will.abson on 17 Oct 2012 at 5:39

• Changed state: Fixed