search

KingSora / KingSora.github.io

3 stars 4 forks source link

Scroll position in callback reports 0 #2

Closed travisrobie closed 5 years ago

travisrobie commented 5 years ago

If you check the scroll position in the 'complete' callback, it reports 0. If you check after another 50ms it will report the correct position.

See https://codepen.io/anon/pen/YROYmX?editors=1010

Thanks for creating this awesome plugin!

Best, Travis

KingSora commented 5 years ago

Good day!

You have accidentaly opened this issue on the incorrect repository. This repository is only responsible for the documentation page. The correct repository would be here.

I've looked into your issue and this is happening because of your very low scroll-duration which is just 1ms in your example.

The coordinates & scroll-infos gets updated if the scroll-event of the viewport-element fires. Unfortunately there seems to be a bit of a native delay before a scroll event gets fired, so the actual scroll events gets fired after the complete callback. To demonstrate / prove this I've created a small demo.

In case you need a workaround until it's fixed, I've created a example for you.

Thank you for the bug report, I'll fix this in the next version of the plugin which will be released pretty soon.

travisrobie commented 5 years ago

Oops! Sorry for putting this in the wrong repo.. haven't filed a report before! Thank you for the workaround.. I really appreciate it!

Travis

KingSora commented 5 years ago

It should be fixed now in v1.6.0. Thanks again for your report!

travisrobie commented 5 years ago

Cool will try it out!

Best, Travis

On Dec 2, 2018, at 6:03 PM, Rene Haas notifications@github.com wrote:

It should be fixed now in v1.6.0 https://github.com/KingSora/OverlayScrollbars/releases/tag/v1.6.0. Thanks again for your report!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/KingSora/KingSora.github.io/issues/2#issuecomment-443550945, or mute the thread https://github.com/notifications/unsubscribe-auth/AI-ye78yGepmfsPw3Of-SQ-Pw_s9EmQtks5u1FxdgaJpZM4Y2US6.