The scroller breaks if you drag'n'drop it outside the scroll area

KingSora / OverlayScrollbars

A javascript scrollbar plugin that hides the native scrollbars, provides custom styleable overlay scrollbars, and preserves the native functionality and feel.

https://kingsora.github.io/OverlayScrollbars

MIT License

3.89k stars 215 forks source link

The scroller breaks if you drag'n'drop it outside the scroll area #18

Closed IgorLesnevskiy closed 6 years ago

IgorLesnevskiy commented 6 years ago

Hello! I found this bug on all my projects. You can see it on your demo page too - http://take.ms/WhYhS 00:00 - 00:05 everything is fine 00:05 - 00:09 I've dragged the scrollbar outside the box 00:10 - 00:26 the scrollbar has become crazy

KingSora commented 6 years ago

Good day!

That seems really weird. I need a bit more info because I can't reproduce this behavior.

Which Browser are you using? (Browser and version please)
Does this happen on other browsers too?
Which Operating System are you using?
Did you press any buttons during this drag&drop? Can you write any buttonpresses you've done (mouse + keyboard)?
Is there any error in the console?
If you trigger this behavior and press the left mouse button on the handle, does this behavior still remain?
Did you find any way to fix this if this bug occured (any button presses and so on)?

Once I know all these, I can investigate in this... it seems really weird though.

IgorLesnevskiy commented 6 years ago

Well, I solved the problem. The problem was related to Tampermonkey extension for Google Chrome. It sounds strange, but after I turned off the extension - the problem was disappeared. Sorry that I wasted your time.

IgorLesnevskiy commented 6 years ago

Well, the only custom script I have is the SaveFrom.net Helper - http://take.ms/ZjAKw. And when I turned it off - everything came back to normal. ¯\(ツ)/¯

KingSora commented 6 years ago

Glad to hear that!

I'll install this plugins too and will try to reproduce it and to fix it. Even if this bug is only present if you have this specific setup I'll try to fix it, because I wanna offer a plugin which is able to work in every enviroment.

If you want to help me, please tell me which buttons you've pressed to abort the drag&drop process, because on the video it seems like you've aborted it with some kind of keypress.

Thank you! :)

IgorLesnevskiy commented 6 years ago

Glad to see your enthusiasm) I make it in three simple steps:

press the Left Mouse Button over the scrollbar
move the cursor outside the box area
unpress the Left Mouse Button

KingSora commented 6 years ago

Alright, after a very long investigation I think I've found the issue. It has to do with passive events and how I was removing them. I don't know exactly why it happened with this script but I've fixed it for sure.

This fix will be implemented in version 1.4.1. Thank you very much! :) If you have other issues, please don't hesitate to report them.

KingSora commented 6 years ago

I've uploaded a demo of the fix to my documentation page: https://kingsora.github.io/OverlayScrollbars/#!demos/basic Please try to trigger this bug again, and confirm if the big is fixed or not.

Thank you!

IgorLesnevskiy commented 6 years ago

I'm very grateful to you for so quick bug fix! Thank you, I'll check it tomorrow and let you know the results.

IgorLesnevskiy commented 6 years ago

Good day! Well, as I can see, the problem was resolved :+1: Should I close the issue?

Thank you!

KingSora commented 6 years ago

Perfect, thank you! :)

I'll close the issue after version 1.4.1 was released, because technically the fix isn't out yet.

KingSora commented 6 years ago

The release is here: https://github.com/KingSora/OverlayScrollbars/releases/tag/v1.4.1

Once again, thank you! :)