Closed vsarangan closed 1 year ago
@vsarangan Good day :)
Thanks for the report. I've published overlayscrollbars
version 2.0.2
which removed position: relative
from the .os-viewport
element by default. You'll have to continue setting position: static
on the root element though, since this is required on it or in your case on a parent element. I've updated your demo here: https://stackblitz.com/edit/angular-xzgdiz?file=src%2Fapp%2Fapp.component.ts
Note: This behavior is related to all browsers not just safari.
@KingSora Good day :) Thanks for your timely response. the above solution that you have provided is still not working in safari 16.2. I suspect this is because of the style overflow-y: scroll, if I remove the style then it is working fine in the safari browser. after removing the overflow-y mouse wheel is not working and hence user needs to manually scroll by using the vertical scrollbar
@vsarangan The only difference in the example I posted is the position: relative
change I explained. I didnt touch anything regarding overflow
The removal of position: relative
has broken my layout. You still have the top
, right
and left
set on the .os-viewport
element and removing the position: relative
breaks those and now all my layout is displaced:
These are the styles for the .os-viewport
element:
You can see (the i
icons) that Chrome complains about having top
, right
and left
on a position: static
element.
Such breaking changes should be better though before implemented and if implemented, the breaking change should be well documented so that we do not blindly update to a broken version.
PS: @KingSora , quoting you to make sure you see this :)
Could you please revert the previous behavior as:
position: relative
is a breaking change@ddenev thanks for the report.. I wounder why this wasnt caught by any of the tests... I'll revert it as soon as I am home and improve the tests
also can you tell me what Operating System and browser youre using?
thank you, @KingSora !
I'm on Windows 10 with Chrome (latest)
@ddenev published v2.0.3
where this change is reverted... Sorry for the inconvenience!
@vsarangan Because of the breaking behavior I consider your case as a design limitation by the plugin. You can keep your workaround as it works in your case (no padding
applied to root element and position: relative
of the immediate parent element).
Describe the bug In Sidemenu, when the user hovers the main menu, respective child menu has to be displayed but that is showing if we apply the overlay scrollbar as directed by the document.
To Reproduce In Sidemenu, when the user hovers the main menu, respective child menu has to be displayed but that is showing if we apply the overlay scrollbar as directed by the document.
Expected behavior Should show the child menu of menu 8
Examples https://stackblitz.com/edit/angular-xt3ejt
Environment
Additional context Fix I tried Style > Position: static in the overlay component and child os-viewport class it is working.