search

Kingcom / armips

An assembler for various ARM and MIPS platforms. Builds available at http://buildbot.orphis.net/armips/
MIT License
363 stars 77 forks source link

Add support for comment lines starting with a hash (#) #134

Closed georgjz closed 6 years ago

georgjz commented 6 years ago

I made a "quick fix" to assemble my older MIPS code. Other MIPS assemblers usually support comments that start with a hash(#).

My changes start at line 195; the others are just my editor removing extra whitespace.

I tested it than with some different older MIPS code files, it seems to work fine. I'm not sure if this might mess with other parts of the tokenizer or assembler/other architectures. If so, I'm happy to help fix that.

I would really like to have comment support with hashes, so I don't have to rewrite my old code (as not to break it for other tools I use).

Kingcom commented 6 years ago

Unfortunately, this conflicts with the official ARM assembly syntax: There # is used as a prefix for immediates, which is supported (but not required) by armips, for example "mov r1,#0x15".

georgjz commented 6 years ago

I almost thought so, since other assembly languages/assemblers use hashes for marking different addressing modes.

So, no easy fix for that. Maybe I'll try and find a better solution for this. I really like armips so far, keep up the good work!