search

Kingcom / armips

An assembler for various ARM and MIPS platforms. Builds available at http://buildbot.orphis.net/armips/
MIT License
363 stars 77 forks source link

.readascii(): Limit read length to sane amount, stop at null terminator #168

Closed Blade2187 closed 4 years ago

Blade2187 commented 4 years ago

I noticed .readascii() doesn't actually stop at null terminators, making its use without a specified length argument questionable. Now it does so. Incidentally, it also would read the entire rest of the file if a length argument wasn't specified. Now it doesn't do so.

Thanks to @Kingcom for input on streamlining this.

Kingcom commented 4 years ago

Could you extend the test for this new behavior?

Prof9 commented 4 years ago

I feel like the readme should also be amended to reflect this new behavior.