Closed Thar0 closed 2 years ago
Hm... this does fix the issue in this case, but mostly by chance. I guess parsing the parameters as an expression is a crutch to begin with. It is really only done to find out how many tokens to use. Perhaps it's a better idea to instead treat it as a comma separated list of any random sequence of tokens here (i.e. take anything until the next comma or separator token).
Commas don't appear in expressions, so this should be relatively safe to do.
Looks good. Can you adjust the Too many macro arguments
check below the loop too? And ideally squash the commits.
Done, I hope this is what you had in mind for the check.
Yeah, looks good! Thanks.
Fixes an issue I encountered in trying to use dollar-prefixed registers as macro arguments. For example, before the fix the following would error with "Invalid macro argument expression":
I'm unsure if this fix is totally correct, or if it may break something else, however all existing tests pass. I will be glad to receive any feedback.