Add support for `weak` elf symbols

Kingcom / armips

An assembler for various ARM and MIPS platforms. Builds available at http://buildbot.orphis.net/armips/

MIT License

363 stars 77 forks source link

Add support for `weak` elf symbols #242

Closed Amjad50 closed 7 months ago

Amjad50 commented 7 months ago

This is a quick fix for crashes when importing file that contain weak symbols.

This only treats it as GLOBAL, and a better implementation would be to handle precedence more appropriately

Kingcom commented 7 months ago

Yeah, that's definitely better than not working at all - thanks! I guess it will work as long as the symbol only appears in one translation unit, though for more realistic template and inline function usage scenarios deduplication would need to be implemented... in general the linking armips performs is extremely primitive, so it would need a bigger rework.

fenhl commented 2 months ago

Any chance we could get a release with this? It's been a while since the last one.