Kingdom-of-The-Moon / FiguraRewriteRewrite

rewrite of the rewrite of figura
GNU Lesser General Public License v2.1
1 stars 1 forks source link

PlayerAPI:getAvatar, AvatarAPI:setNBT, AvatarAPI:getModels #103

Closed BlueMoonJune closed 1 year ago

BlueMoonJune commented 1 year ago

Various methods to deal with others' avatars, and an avatar.json field "allowGetAvatar" (true by default)

ChloeSpacedOut commented 1 year ago

I feel that adding a back-door to other people's avatars, especially one that's opt-out rather than opt-in, is a really bad idea. People can already communicate between avatars, so this doesn't even add extra functionality in terms of multi-avatar applications. It's literally just a way to force other avatars to do things. Not great :p

ChloeSpacedOut commented 1 year ago

This also 100% wouldn't work well with the trust menu, since it'd execute on your own avatar, and make it harder to trace who sent it. And it'd bypass your trust settings, so you could just crash others and bypass trust settings, or make HUD model parts and cover other's screens. There's like, only bad applications :p

GrandpaScout commented 1 year ago

Both of these functions are already possible in base Figura (and they are opt-in too!)

avatar:store("models", models)
avatar:store("avatar", avatar)

image

BlueMoonJune commented 1 year ago

Both of these functions are already possible in base Figura (and they are opt-in too!)

avatar:store("models", models)
avatar:store("avatar", avatar)

image

oh yeah that 100% works, didnt think about that

This also 100% wouldn't work well with the trust menu, since it'd execute on your own avatar, and make it harder to trace who sent it. And it'd bypass your trust settings, so you could just crash others and bypass trust settings, or make HUD model parts and cover other's screens. There's like, only bad applications :p

i dont know how it would bypass your trust settings, because you arent executing code on their side. and making the system opt-in instead of opt-out is also very easy, but GS's solution works so this is kinda pointless.