Kingdom-of-The-Moon / FiguraRewriteRewrite

rewrite of the rewrite of figura
GNU Lesser General Public License v2.1
1 stars 1 forks source link

Incompatible with Super Secret Revival mod #61

Closed Aces-and-Jacks closed 1 year ago

Aces-and-Jacks commented 1 year ago

https://mclo.gs/IIzCfa3

Aces-and-Jacks commented 1 year ago

like when I click the + button

lenrik1589 commented 1 year ago

I believe this issue has been fixed in the newer version (it appears that you are using latest release, and the issue has been fixed in commits), could you try running latest build?

lenrik1589 commented 1 year ago

Note, however, that many avatars will not work in this build because of changes introduced in the time since last release.

Aces-and-Jacks commented 1 year ago

https://mclo.gs/VLWAEbr

used figura-0.1.0-rc.13+1.19.2.jar but issue still occurred

Aces-and-Jacks commented 1 year ago

I'll try on a fresh instance. maybe there's a mod conflict

Aces-and-Jacks commented 1 year ago

yup. conflict

Aces-and-Jacks commented 1 year ago

I'll message when I find it

lenrik1589 commented 1 year ago

If you know how to do it, could you add JVM flag -Dmixin.debug = true and send output of that? It would show which mod added the mixin that causes the error.

Aces-and-Jacks commented 1 year ago

I was just gonna do a binary search. would I put that as an argument?

Aces-and-Jacks commented 1 year ago

I've never used java arguments

lenrik1589 commented 1 year ago

Yes, since you are using Prism Launcher it would just go in instance settings, Java, Java arguments and add -Dmixin.debug.verbose=true into it. (oops, just figured out that with just -Dmixin.debug=true some mods may cause game to crash)

Aces-and-Jacks commented 1 year ago

https://mclo.gs/MjhlGju

Aces-and-Jacks commented 1 year ago

dang. almost 10k lines of code

lenrik1589 commented 1 year ago

I am confused, it appears that the function that fails is generated by mixin, but it is not created at runtime?

uhm, is there any mod that would change ui behavior (or more of sounds)?

Aces-and-Jacks commented 1 year ago

like a mod that adds sounds?

Aces-and-Jacks commented 1 year ago

not any sound mods that I have. I'll just continue with the binary search

lenrik1589 commented 1 year ago

found the issue

Aces-and-Jacks commented 1 year ago

what mod?

lenrik1589 commented 1 year ago

I don't know what mod is using that information, but pressing any button with an icon instead of text will crash your game because their message is currently being set to null instead of Component.empty().

Aces-and-Jacks commented 1 year ago

ah...well i'll continue looking then

Aces-and-Jacks commented 1 year ago

FINALLY. after a while I found the issue. Super Secret Revival is the mod

lenrik1589 commented 1 year ago

Huh? Why would something like that mixin into base class? I'll look into what they are doing, but it does seem like not something they should be doing?

Aces-and-Jacks commented 1 year ago

And it's the only mod I can't make an issue on either

Francy-chan commented 1 year ago

Huh? Why would something like that mixin into base class? I'll look into what they are doing, but it does seem like not something they should be doing?

this https://git.oat.zone/oat/super-secret-revival/src/branch/1.18/src/main/java/zone/oat/supersecretrevival/mixin/CancelClickSoundMixin.java

lenrik1589 commented 1 year ago

As an alternative, Figrua provides functional of enabling post render effects if you wish to have that

Aces-and-Jacks commented 1 year ago

I'm guessing it'd be something they need to do on their end so I'll just close this

Aces-and-Jacks commented 1 year ago

Unless anyone else knows how to post an issue there

lenrik1589 commented 1 year ago

working on it

Aces-and-Jacks commented 1 year ago

Would sending an email to her GitHub profile be a bad way to do it?

lenrik1589 commented 1 year ago

The developer of Super Secret Revival has been contacted and confirmed that it'll fix the bug soon ("sometime later today, hopefully")

Aces-and-Jacks commented 1 year ago

Got it, thanks. Even though this was an issue I was having and it wasn't from the figura mod, you've been an incredible help

oatmealine commented 1 year ago

hi! yes - i'll fix this in the near future, sorry for the troubles!! (i'm hoping filing issues on my git instance will become a lot less difficult once federation rolls around..)

in the future, you could always just ping me on github instead!

Aces-and-Jacks commented 1 year ago

in the future, you could always just ping me on github instead!

I've only done commenting on GitHub repositories...actually I forgot about the @ function. Any future issues I'll do that then

oatmealine commented 1 year ago

1.3 shooould fix this unless i've royally messed something up