search

Kingdom-of-The-Moon / FiguraRewriteRewrite

rewrite of the rewrite of figura
GNU Lesser General Public License v2.1
1 stars 1 forks source link

First/Third Person Skull Render Contexts #88

Closed KitCat962 closed 1 year ago

KitCat962 commented 1 year ago

Removes the LEFT_HAND and RIGHT_HAND skull contexts in favor of FIRST_PERSON_LEFT_HAND, FIRST_PERSON_RIGHT_HAND, THIRD_PERSON_LEFT_HAND, and THIRD_PERSON_RIGHT_HAND, for just that additional flexibility.

This uses the ItemDisplayContext available when rendering the skull as a held item, so there is theoretically a case where it is not one of the four valid ItemDisplayContexts. I was undecided whether it should follow the leftHanded boolean from the old logic, or if it should return OTHER for debug purposes. Its currently using the boolean, but it should be easy to swap.

now I can make my plushy take up half the screen in first person, and take up half the screen in third person

KitCat962 commented 1 year ago

oh right. linux gradlew execute permissions. On my linux distribution, you need to explicitly mark files as being executable. Its a pain.