KingdomFirst / Bulldozer

A multi-component Windows app to convert data into Rock RMS from other church management systems.
https://www.rockrms.com/
Apache License 2.0
8 stars 9 forks source link

Bug fixes from migration run using Slingshot files #100

Closed guymaness2 closed 7 months ago

guymaness2 commented 8 months ago

Thank you for your code contribution, we will take your code suggestion into consideration. It will be reviewed, and based on code quality and need addressed, we will determine acceptance. If this code addresses a feature request or issue, be sure to link to that issue.

Description

What does the change add or fix?

Release Notes

What does the change add or fix in a succinct statement that will be read by clients?

Requested By

Who reported, requested, or paid for the change?

Warranty


Screenshots

Does this update or add options to the block UI?

no


Change Log

What files does it affect?

Migrations/External Impacts

Is it a breaking change for other versions/clients?

no

guymaness2 commented 8 months ago

Ended on https://github.com/KingdomFirst/Bulldozer/pull/100/commits/67bacca4510b3479d82788c8d135d796f3db596b

guymaness2 commented 8 months ago

@nateh777 resolved all issues from code review. Reworked and tested Notes import section. Ready for review.

guymaness2 commented 7 months ago

@nateh777 pulled changes in and rebuilt. Was there something you needed me to test, or are we good for merge?

nateh777 commented 7 months ago

@guymaness2 I believe just attributeDefinedTypeDict changes being checked to ensure we really are using the proper keys everywhere, otherwise I think it was good to go. I'll approve.