KingdomFirst / Bulldozer

A multi-component Windows app to convert data into Rock RMS from other church management systems.
https://www.rockrms.com/
Apache License 2.0
8 stars 9 forks source link

B: Group Images are not completely valid on Import #59

Closed nateh777 closed 2 years ago

nateh777 commented 2 years ago

Expected Behavior

Group images to be valid on import.

Current Behavior

What is the current behavior?

For some reason, the Group Image file type that bulldozer creates looks completely valid and is usable, but the images show as broken links until I go into Admin Tools > Rock Settings > General Settings > File Types, click to “edit” the new Group Image file type and simply re-save it. It doesn’t require any changes, but apparently creating the file type the way we have Bulldozer doing it misses a nuance that Rock’s UI does to make the images actually display properly. The actual image urls don’t change at from before to after the fix.

Here is the bulldozer code that adds the new FileType for those that don’t already exist: https://github.com/KingdomFirst/Bulldozer/blob/54d30f1932ab8315e0a86627786cce62852c7344/Bulldozer.BinaryFile/BinaryFileComponent.cs#L238

The strange thing is that “Group Image” appears to have been missed in the definitions (link below) that line 130 from above link is calling, yet it still actually creates the new FileType: https://github.com/KingdomFirst/Bulldozer/blob/master/Bulldozer/App.config#L16

Failure Information (for bugs)

Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Import Group Images
  2. Try to view these images without any corrections, they are invalid.

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

nateh777 commented 2 years ago

Fixed in #66