KingdomFirst / Bulldozer

A multi-component Windows app to convert data into Rock RMS from other church management systems.
https://www.rockrms.com/
Apache License 2.0
8 stars 9 forks source link

Reference and Version Update #94

Closed nateh777 closed 9 months ago

nateh777 commented 9 months ago

Description

What does the change add or fix?

Version update and reversed change to remove dll and compile into exe instead due to no actual references to ical, which will not be copied to output folder if not used.


Release Notes

What does the change add or fix in a succinct statement that will be read by clients?

Requested By

Who reported, requested, or paid for the change?

Warranty


Screenshots

Does this update or add options to the block UI?

No


Change Log

What files does it affect?

Migrations/External Impacts

Is it a breaking change for other versions/clients?

No

guymaness2 commented 9 months ago

@nateh777 The changes show you also removed Newtonsoft reference from both the bulldozer project and packages.config. You didn't mention it in your description, so I just wanted to make sure it was intentional before accepting.

nateh777 commented 9 months ago

@nateh777 The changes show you also removed Newtonsoft reference from both the bulldozer project and packages.config. You didn't mention it in your description, so I just wanted to make sure it was intentional before accepting.

@guymaness2 sorry, yes that was intentional for the same reason. It is already included in the executable, no need to have the actual dll