KingdomFirst / rock-attended-checkin

Attended Checkin plugin for Rock RMS
http://rockrms.com
MIT License
9 stars 8 forks source link

Print All Button will not print if Print Individual Labels is set to True #57

Closed BEGamache closed 4 years ago

BEGamache commented 5 years ago

https://github.com/KingdomFirst/rock-attended-checkin/blob/8c9b0bda8f94024c47ea4874f68d880107afcaf0/cc_newspring/AttendedCheckin/Confirm.ascx.cs#L534

Ran into a couple issues with printing. If the Print Individual Labels attribute is set to True and the Print All button is clicked, labels will not print. If Print Individual Labels is set to False and the Print All button is clicked, it will properly print all labels. This is if the multiple groups you are checking into are of the same Group Type.

In order to get check in to print all labels I had to modify line 534 of the Confirm block to: if ( checkinArray.Count == 1 || printIndividually ) This will also work: if ( checkinArray.Count >= 1 )

https://github.com/KingdomFirst/rock-attended-checkin/blob/8c9b0bda8f94024c47ea4874f68d880107afcaf0/cc_newspring/AttendedCheckin/Confirm.ascx.cs#L523

The other issue I am facing stems from the first issue but includes an issue when checking into multiple Group Types. If I leave Print Individual Labels set to True, and I'm checking into multiple Group Types, I have to comment out line 523 else it will not Print All. If I set Print Individual Labels to False, only one Group Type will have labels printed when I click Print All.

Haven't been able to figure out the Group Type issue yet but I believe it is something the that same area of code.

BEGamache commented 5 years ago

I've done a little more testing and the second issue I am having arises from both Group Types using the same check in label. When I changed one of the Group Types' labels to a different label, and Print Individual set to False, it prints fine (1 label with 2 selected groups listed and a second label with the selected group from another Group Type). Not certain if this is a lava label merge issue or something in the Confirm block.

Update: The unattended/core check in does the same thing so the 2nd issue isn't specifically an Attended Check in issue.