search

KingdomFirst / rock-attended-checkin

Attended Checkin plugin for Rock RMS
http://rockrms.com
MIT License
9 stars 8 forks source link

Not recognizing Check In By DataView #73

Closed MicahO closed 4 years ago

MicahO commented 5 years ago

This week we switched our check-in rules to "By Data View" from "By Age/Grade." All of our unattended checkin stations work fine, but at our attended check-in we now have the option to check parents into rooms they should not be able to join. (ie, the parents can be checked into a 3-year-old room using Attended Checkin).

This can be tested by setting up a check-in area with "Check In By Data View" and then attempting to check in a family. You will see the parents listed, even if they do not show up in any of the data views.

MicahO commented 5 years ago

It occurred to me after I wrote the initial bug report that the issue might be slightly more complex. Many of our rooms use multiple data views to know who is in the room. For example, we have a room for all three-year-olds whose first names start with A-L. This is done by setting up two data views ("3 years old" and "Last Name between A-L"), BOTH of which must be satisfied to check into the room (see screenshot). It's possible that Attended Check-In is treating this combination as OR instead of AND. Screen Shot 2019-09-15 at 9 40 31 AM

MicahO commented 5 years ago

Here's a screen capture video I did today that demonstrates the bug more clearly:

https://youtu.be/UsqXNRbEFA0

MicahO commented 4 years ago

Hey @KelleyLangkamp @carlatKFS is there any way I can help get this resolved? I'm going to have to fix this; it's causing too much trouble. If this bug isn't going to be addressed then I need to rewrite our check-in system to avoid it.

carlatKFS commented 4 years ago

Needs to be enhanced to work with new Rock features in v9. (.e.g. Checkin by Dataview)