KingdomFirst / rock-attended-checkin

Attended Checkin plugin for Rock RMS
http://rockrms.com
MIT License
9 stars 8 forks source link

E: Barcode Scanning returns no results when entered into search field #89

Open calvmann opened 3 years ago

calvmann commented 3 years ago

I have tried barcode scanning fix (pull request #85 ) but have not had any success.

Attended Check-in properly scans the barcode but doesn't pull up any families or people. I have clicked the back button to make sure the right barcode value was entered into the search bar and it was. I have also made sure the value that was searched matches the alternate ID on the person's profile record. Scanning with Core's check-in works great so I don't think it is a workflow issue but a block code issue in Attended Check-in, unless something isn't getting passed from the workflow back to the block or viewstate.

Attended Checkin Plugin Version: 1.8.3 Rock RMS version: 12.1

https://user-images.githubusercontent.com/38733976/123692658-b3abd980-d81c-11eb-961a-cfd027ec1696.mp4

nateh777 commented 3 years ago

@calvmann there is a hidden text field it uses when a barcode scanner is used that will take the id as the input and search for it. Similar to what the core blocks use. Can you provide a recording of it not working with a barcode scanner as well? The field cannot be in focus when using a barcode scanner and why that setting needs to be set appropriately. I know it is in the field when you hit back and you would think you could search for the same id in the text field but you cannot.

We can look at adding it so that if a barcode is entered in the search field it will also search for it, but that was originally by design due to phone numbers and barcodes sometimes being similar and would therefor be a feature request and not a bug.

calvmann commented 3 years ago

@nateh777 here's a video of the same barcode # (but scanned) and the same result. Thanks for your help!

https://user-images.githubusercontent.com/38733976/123845182-7f4a2300-d8d9-11eb-86b4-6a18acc5da18.MOV

nateh777 commented 3 years ago

I know it is finicky, but can you try it with a fresh load of the attended check-in? Or reload the page and then scan? There should not be a cursor in the search field when you scan.

No cursor: image

Cursor: image

I think we have to come up with a solution since it appears to not work as intended. The field cannot be in focus at all otherwise, as you notice, it fills out the field and hits search, which is similar to copy and pasting the value in. How core check-in gets around this is if you want barcode scanning, but also want search, if you want to manually input something you have to actually click/tap a button before you can enter text in. The original designers were assuming that you could do both but it appears to be confusing. Perhaps that is the solution is that if you "enable" barcode scanning it does not have the search field display, but a button instead or we come up with a way that the search field can search barcodes as well.

We will add it to our task list to come up with a solution when we can. If you would like to help prioritize this issue please contact sales@kingdomfirstsolutions.com

calvmann commented 3 years ago

Thanks @nateh777 that was it! Sorry to hijack this thread but is there a way to assign barcodes in the attended checkin plugin? Seems that the only way is from our Rock portal. This has not been a concern before since we haven't been using keychain tags due to this 'bug'

nateh777 commented 3 years ago

Barcodes used to be added to the family record and as such we did not have an area to "edit" a family as a whole. You could add barcodes with the "Add Family" option but that current capability does have a bug that we found... https://github.com/KingdomFirst/rock-attended-checkin/issues/80

Now that the barcodes are stored on individuals, it would be possible to add that field fairly easily to the edit form, but would require a sales quote. If you are interested in funding this feature you can email sales@kingdomfirstsolutions.com. Feel free to also submit it as an "issue" with the label "enhancement" so we can have it on our list of suggested improvements if anyone funds any other features.

nateh777 commented 3 years ago

I am going to leave this issue open as an enhancement request for the following: