Open enocol opened 11 months ago
Hi @enocol, @Kingno3l,
Great job so far! π You've done well, and you're almost there for the next project βοΈ, but there are a few issues π that you still need to work on.
It's okay to have bugs in your code. π Please see this code review as an opportunity to learn practical coding skills and discover new tips that can improve your code quality π― and help you get even better πΌ.
I will guide you on how to address these areas down below π.
β Number of cards in Backlog is equal to 17 β Has link to their GitHub project β information about the number of people in their group
You can also consider: -You've done a commendable job by adding all 17 tasks to your project. However, as per the project requirements, it's essential to ensure that each team member assigns themselves to the cards from all categories. This ensures a fair distribution of time estimates and prevents one person from handling all of the most time-consuming tasks. Please review your project and make sure that all cards on your Kanban board have assignees. Decide who will be the assignee for the cards marked as group tasksβthis can be one person or all team members, as appropriate. By adhering to this requirement, you'll ensure that the project is well-distributed among team members and that everyone is actively participating in the tasks. Keep up the great teamwork! ππ₯ Cheers and Happy coding!πππ
Check the comments under the review.
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Contact me: Shahadat Hossain | |||
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi @Kingno3l, @enocol,
Your project is complete! There is nothing else to say other than it's time to merge it :shipit: Congratulations! π
β The number of cards in the Backlog is equal to 17 β All tasks assign to everyone β information about the number of people in their group
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Contact me: Shahadat Hossain | |||
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Kanban board
Two people in this group. All task completed according to project requirement for Kanban board setup
Note: Github project repo was rename from kanban board to spaceX