Kingno3l / SpaceX

0 stars 1 forks source link

Kanban Board setup #26

Open enocol opened 11 months ago

enocol commented 11 months ago

Kanban board

Two people in this group. All task completed according to project requirement for Kanban board setup

Note: Github project repo was rename from kanban board to spaceX

shahadat3669 commented 11 months ago

Hi @enocol, @Kingno3l,

Great job so far! πŸ‘ You've done well, and you're almost there for the next project ⏭️, but there are a few issues πŸ› that you still need to work on.

Don't Worry πŸ™

It's okay to have bugs in your code. πŸ†— Please see this code review as an opportunity to learn practical coding skills and discover new tips that can improve your code quality πŸ’― and help you get even better πŸ’Ό.

I will guide you on how to address these areas down below πŸ‘‡.

Highlights

βœ… Number of cards in Backlog is equal to 17 βœ… Has link to their GitHub project βœ… information about the number of people in their group

Required Changes ♻️

You can also consider: -You've done a commendable job by adding all 17 tasks to your project. However, as per the project requirements, it's essential to ensure that each team member assigns themselves to the cards from all categories. This ensures a fair distribution of time estimates and prevents one person from handling all of the most time-consuming tasks. Please review your project and make sure that all cards on your Kanban board have assignees. Decide who will be the assignee for the cards marked as group tasksβ€”this can be one person or all team members, as appropriate. By adhering to this requirement, you'll ensure that the project is well-distributed among team members and that everyone is actively participating in the tasks. Keep up the great teamwork! 🌟πŸ‘₯ Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Have any doubt ❓

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Contact me: Shahadat Hossain
GitHub LinkedIn Slack Email

⚠️ WARNING ⚠️

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

shahadat3669 commented 11 months ago

Hi @Kingno3l, @enocol,

Your project is complete! There is nothing else to say other than it's time to merge it :shipit: Congratulations! πŸŽ‰

Highlights

βœ… The number of cards in the Backlog is equal to 17 βœ… All tasks assign to everyone βœ… information about the number of people in their group

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Have any doubt ❓

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Contact me: Shahadat Hossain
GitHub LinkedIn Slack Email

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.