search

KingsburyLab / pyEQL

A Python library for solution chemistry
Other
64 stars 17 forks source link

alpha: fix incorrect calculation #113

Closed rkingsbury closed 5 months ago

rkingsbury commented 5 months ago

Fixes incorrect calculation results from equilibrium.alpha. Note that this utility function is currently provided only as a convenience; it is not utilized anywhere within pyEQL at present.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.18%. Comparing base (4233b9f) to head (739e9ba).

:exclamation: Current head 739e9ba differs from pull request most recent head bb7cbc2. Consider uploading reports for the commit bb7cbc2 to get more accurate results

Files Patch % Lines
src/pyEQL/equilibrium.py 81.81% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #113 +/- ## ========================================== + Coverage 80.52% 82.18% +1.65% ========================================== Files 10 10 Lines 1453 1448 -5 Branches 251 250 -1 ========================================== + Hits 1170 1190 +20 + Misses 248 221 -27 - Partials 35 37 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.