search

KingsburyLab / pyEQL

A Python library for solution chemistry
Other
64 stars 17 forks source link

Solution: fixes failures when oxi state is unknown #117

Closed rkingsbury closed 5 months ago

rkingsbury commented 5 months ago

Closes #116 by improving handling of unknown oxidation states.

Also bumps pre-commit versions (unrelated)

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.28%. Comparing base (02e28bb) to head (934db1f). Report is 1 commits behind head on main.

Files Patch % Lines
src/pyEQL/solution.py 57.14% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #117 +/- ## ========================================== + Coverage 82.24% 82.28% +0.03% ========================================== Files 10 10 Lines 1453 1456 +3 Branches 293 293 ========================================== + Hits 1195 1198 +3 Misses 220 220 Partials 38 38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.