Closed rkingsbury closed 5 months ago
Attention: Patch coverage is 70.23810%
with 25 lines
in your changes are missing coverage. Please review.
Project coverage is 82.08%. Comparing base (
296be67
) to head (9612d19
). Report is 9 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/pyEQL/solution.py | 62.50% | 17 Missing and 1 partial :warning: |
src/pyEQL/engines.py | 76.92% | 3 Missing :warning: |
src/pyEQL/equilibrium.py | 50.00% | 3 Missing :warning: |
src/pyEQL/activity_correction.py | 85.71% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary
The warning / logging system in
pyEQL
has been intentionally verbose and a bit haphazard, prompting confusion on the part of users (see #52 ). This PR overhauls the logging system bylog_level
kwarg toSolution.__init__
that allows users to control the level of verbosity of the messages they will see in stdoutwarnings
in most casesCloses #52