Closed rkingsbury closed 2 months ago
Attention: Patch coverage is 58.33333%
with 10 lines
in your changes missing coverage. Please review.
Project coverage is 81.37%. Comparing base (
671078e
) to head (70af876
). Report is 10 commits behind head on main.:exclamation: Current head 70af876 differs from pull request most recent head edb828c
Please upload reports for the commit edb828c to get more accurate results.
Files | Patch % | Lines |
---|---|---|
src/pyEQL/activity_correction.py | 62.50% | 3 Missing :warning: |
src/pyEQL/engines.py | 40.00% | 2 Missing and 1 partial :warning: |
src/pyEQL/equilibrium.py | 33.33% | 2 Missing :warning: |
src/pyEQL/solution.py | 60.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary
Fixes #141 . This was ultimately caused by a subtle problem with charge balancing when elements with multiple oxidation states (at least, as recognized by
oxi_state_guesses
) were present in theSolution
.