Closed rkingsbury closed 3 months ago
Attention: Patch coverage is 90.62500%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 82.93%. Comparing base (
8bef6a4
) to head (0e0ee6a
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/pyEQL/solution.py | 90.32% | 2 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[1.1.3] - 2024-07-28
Fixed
Solution
: Fix a bug in which settingbalance_charge
topH
could result in negative concentration errors when charge balancing or afterequilibrate
was called.Solution
now correctly enforces the ion product of water (Kw=1e-14) whenever adjusting the amounts of H+ or OH- for charge balancing.Added
Solution._adjust_charge_balance
: Added a privat helper method to consolidate charge balancing code used in__init__
andequilibrate
.