search

KingsburyLab / pyEQL

A Python library for solution chemistry
Other
66 stars 20 forks source link

CI improvement: add lowest-direct dependency resolution #157

Closed rkingsbury closed 2 months ago

rkingsbury commented 3 months ago

We should modify the GitHub CI tests to include lowest-direct dependency resolution, as suggested for another package in https://github.com/materialsproject/jobflow/pull/640#issuecomment-2245947952

I think this would best be done in the post-merge workflow (called test-comprehensive) rather than the standard testing work flow, but I'm open to suggestions.

abhardwaj73 commented 3 months ago

Hi Ryan, Looks like the post-merge workflow you mentioned is called post-process.yml.

In the PR I've added the following lines:

        version:
          - { python: "3.9", resolution: highest, extras: strict }
          - { python: "3.10", resolution: lowest-direct, extras: strict }
          - { python: "3.11", resolution: highest, extras: non-strict }
          - { python: "3.12", resolution: lowest-direct, extras: non-strict }

instead of python-version: ['3.9', '3.10', '3.11']

as done in https://github.com/materialsproject/jobflow/pull/640#issuecomment-2245947952