KingsburyLab / pyEQL

A Python library for solution chemistry
Other
65 stars 17 forks source link

Housekeeping: address some repo-review items #66

Closed rkingsbury closed 9 months ago

rkingsbury commented 11 months ago

Address some of the items identified by the scientific python repo-review tool

I don't necessarily want to do everything it suggests, but some of the ones that do make sense are:

DhruvDuseja commented 11 months ago

@rkingsbury Can I take a crack at this? Never worked on toml files or pre commit files before, so it should be interesting!

rkingsbury commented 11 months ago

Sure, feel free!

DhruvDuseja commented 11 months ago

Thanks @rkingsbury. I've made the changes and run the repo review again and see that the changes have taken effect according to this: https://scientific-python.github.io/repo-review/?repo=DhruvDuseja%2FpyEQL&branch=repo_review_changes

Can you please let me know if there's anything else I need to test on these changes? Thanks

rkingsbury commented 9 months ago

Thanks again @DhruvDuseja !