Closed rkingsbury closed 9 months ago
@rkingsbury Can I take a crack at this? Never worked on toml files or pre commit files before, so it should be interesting!
Sure, feel free!
Thanks @rkingsbury. I've made the changes and run the repo review again and see that the changes have taken effect according to this: https://scientific-python.github.io/repo-review/?repo=DhruvDuseja%2FpyEQL&branch=repo_review_changes
Can you please let me know if there's anything else I need to test on these changes? Thanks
Thanks again @DhruvDuseja !
Address some of the items identified by the scientific python repo-review tool
I don't necessarily want to do everything it suggests, but some of the ones that do make sense are:
pyproject.toml
sectionprettier
hook to format .md and .json files--show-fixes
for ruff lintingmypy
configuration, but do NOT add to pre-commit hooks. I think mypy is valuable and improves code quality, but it can be very frustrating for new developers