Closed rkingsbury closed 10 months ago
Attention: 11 lines
in your changes are missing coverage. Please review.
Comparison is base (
0c749b8
) 78.57% compared to head (5c4ea1b
) 78.50%.
Files | Patch % | Lines |
---|---|---|
src/pyEQL/engines.py | 85.71% | 6 Missing and 3 partials :warning: |
src/pyEQL/functions.py | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary
Misc. enhancements to the PHREEQC implmentation
phreeqpython
solution instance in between calls, only re-instantiating when the composition changes. This helps considerably with performance.NativeEOS
andPhreeqcEOS
to eliminate redundant code via inheritanceequilibrate_phreeqc()