search

KingsburyLab / pyEQL

A Python library for solution chemistry
Other
65 stars 17 forks source link

Revert change to __add__ #93

Closed rkingsbury closed 7 months ago

rkingsbury commented 7 months ago

Reverts change to Solution.__add__ in #92 . Any class that inherits from Solution is not guaranteed to have the same call signature in __init__, so such classes will probably need to re-implement __add__ anyway. Explicitly invoking the classname Solution rather than impliciltly (self.__class__) seems to be more consistent with how magic methods are usually implemented.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (95ede9b) 80.30% compared to head (a6a773a) 80.30%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #93 +/- ## ======================================= Coverage 80.30% 80.30% ======================================= Files 10 10 Lines 1447 1447 Branches 252 252 ======================================= Hits 1162 1162 Misses 250 250 Partials 35 35 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.