Peer to peer code review

charlesgobina commented 2 years ago

Hi @KingsleyIbe 👋🏾 Great work on implementing the project. It looks great but there are a few issues I want to draw your attention to.

The live link to the project you put concerning the GitHub finder does not redirect me to a live project but a README file. I suggest you put the actual live link to the project
As from screen size 768px, the burger button is no longer visible, making it impossible for users to access the menu.
Still around this range, some of the site contents don't extend across all the screens, making the site look ununiform. I suggest you use a responsive screen width for all screen sizes.
On mobile view, the burger button does not work when clicked. I suggest you take a look at your JS code to ensure everything is fine

Happy coding 🎈

KingsleyIbe commented 2 years ago

Hello Charles,

Thanks for the feedback, I will implement the suggested changes.

eddie-2020 commented 2 years ago

Hello @KingsleyIbe , I think your project looks fine but considering what @charlesgobina said In his first description Is something you may need to address, Happy coding bro!

KingsleyIbe commented 2 years ago

Hello @oluyaratosin123

Thank you for your suggestions, be sure changes will be implemented.

KingsleyIbe / myPortifolioSite

Peer to peer code review #24