Kinlei / MaterialLua

A material design library, designed for use in Roblox.
65 stars 77 forks source link

Usage of compound operators breaks the library on some exploits #1

Closed greenmancode closed 4 years ago

greenmancode commented 4 years ago

When I wrote the documentation for this library, everything was working fine because I used Synapse X. Today I tried to use Sentinel, and an error message appeared. After pasting the script directly into the executor, I got the following error message:

[string "local Player = game.Players.LocalPlayer..."]:468: '=' expected near '+'

The issue which causes this error is found on Line 468:

-- Line 468
Total += (typeof(Value) == "function") and 1 or 0

The += operator is used 10 more times within the script at these locations:

The usage of compound operators is understandable since Roblox introduced them in build 435 (see here), but not all exploits appear to have updated their standards to make the compound operators work. I would recommend testing the library on exploits beside Sentinel and Synapse to see if this issue impacts other major exploits and if so, use normal arithmetic statements for proper compatibility.

Kinlei commented 4 years ago

Changed all to normal arithmetic operations for more compatibility. Will probably revert to compounds (to replicate my style/compatibility) when exploit owners decide to pick up.