search

Kinnara / ModernWpf

Modern styles and controls for your WPF applications
MIT License
4.47k stars 447 forks source link

Strong Name Signing #242

Open michael-damatov opened 3 years ago

michael-damatov commented 3 years ago

Please sign the package assemblies with a strong name key. This would eliminate the following warning:

warning CS8002: Referenced assembly 'ModernWpf.Controls, Version=0.9.2.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.

when the package is used by a signed assembly.

ShankarBUS commented 3 years ago

But doesn't code signing require money?

This project is opensource. You can't expect the author to spend their own money on this project.

Is it that necessary BTW?

michael-damatov commented 3 years ago

No, it doesn't require any money (this is not a code signing certificate issued by a CA). A key can easily be created by the VS.

alex-lapuka commented 1 year ago

@Kinnara Are there any updates on that issue? It seems like the latest release is still without the strong name. That is preventing that NuGet package from using at any strong-named app.