Kinovarobotics / kinova-movo

Source code of the Kinova MOVO platform
BSD 3-Clause "New" or "Revised" License
44 stars 37 forks source link

Remove realsence support #74

Closed Philippe117 closed 4 years ago

Philippe117 commented 4 years ago

Justification

Not used

Since the realsence camera is not used on the MOVO, it is not needed in the source code.

Buggy

Here is a sample of the error provoked by realsence when running catkin_make:

/root/movo_ws/src/movo_common/movo_third_party/realsense2_camera/src/base_realsense_node.cpp:1394:1:   required from here
/opt/ros/kinetic/include/librealsense2/hpp/rs_frame.hpp:1131:13: error: no match for call to ‘(rs2::asynchronous_syncer) (rs2::frame)’
             on_frame_function(frame{ fref });
             ^

Test

To test this branch, follow these steps:

cd movo_ws/src
git fetch
git checkout fix/kinetic-devel/librealsence_compilation
cd ..
rm -rf devel build
catkin_make

If no errors occur, the test is a success.