Kinovarobotics / ros2_kortex

ROS2 driver for the Gen3 Kinova robot arm
Other
51 stars 47 forks source link

Depend on gz-ros2-control instead of gazebo-ros2-control #159

Open abake48 opened 1 year ago

abake48 commented 1 year ago

We currently don't support Gazebo classic and have focused on support Ignition Gazebo so we should no longer depend on gazebo_ros2_control and instead depend on gz_ros2_control.

This will benefit the user because gazebo-ros2-control and gz-ros2-control currently conflict with each other.

moriarty commented 1 year ago

Rolling Binary Build Rolling + Main failed:

  ERROR: the following rosdeps failed to install
    apt: command [apt-get install -y -qq ros-rolling-gz-ros2-control] failed
  '( source /home/runner/work/ros2_kortex/ros2_kortex/.work/upstream_ws/install/setup.bash && rosdep install -q --from-paths /home/runner/work/ros2_kortex/ros2_kortex/.work/target_ws/src --ignore-src -y | grep -E '(executing command)|(Setting up)' ; )' returned with 1
'install_target_dependencies' returned with code '1' after 0 min 37 sec

I think this is in a weird state right now due to the recent changes upstream https://github.com/ros/rosdistro/pull/37773

It looks like gz-ros2-control is available on main with Iron but not yet for Rolling. It is available on testing for rolling but our github jobs are setup to fail fast and not run the other matrix option.

image

image

This just means we need to wait until the next package sync for Rolling before merging.

moriarty commented 1 year ago

https://packages.ros.org/ros2/ubuntu/pool/main/r/

http://packages.ros.org/ros2-testing/ubuntu/pool/main/r/

henningkayser commented 6 months ago

@abake48, @moriarty, @smoya23 any chance this could be moved forward? gazebo-ros2-control has been phased out, so Rolling and Jazzy builds are failing because of the missing dependency.