[conan] Use the closes build type that is compatible

Kinovarobotics / ros_kortex

ROS packages for KINOVA® KORTEX™ robotic arms

Other

160 stars 159 forks source link

[conan] Use the closes build type that is compatible #280

Closed gergondet closed 1 year ago

gergondet commented 1 year ago

See #279

felixmaisonneuve commented 1 year ago

Following your suggestion in #279, could you add something like "Note : Only Release and Debug are supported for the CMAKE_BUILD_TYPE argument" in the main readme file after the catkin_make instruction?

gergondet commented 1 year ago

Hi @felixmaisonneuve

Do you mean instead of this PR or in addition to this PR?

Thanks

felixmaisonneuve commented 1 year ago

@gergondet in addition this PR

gergondet commented 1 year ago

@felixmaisonneuve thanks, I have added the note in 24da986 (#280)

felixmaisonneuve commented 1 year ago

This looks good, thank you for your work

I am sory I did not merge this earlier

Regards, Felix