search

Kinovarobotics / ros_kortex

ROS packages for KINOVA® KORTEX™ robotic arms
Other
153 stars 155 forks source link

Fix typos in joint limits #285

Closed travers-rhodes closed 1 year ago

travers-rhodes commented 1 year ago

I was running into some confusing errors until I realized that the URDF joint limits don't match the robots default joint limits in https://www.kinovarobotics.com/uploads/User-Guide-Gen3-R07.pdf, so it was very easy to accidentally have my code try to send the robot past its safety limits. Hopefully this change makes sense.

felixmaisonneuve commented 1 year ago

Hi @travers-rhodes, I see you changed the limits for 7dof arm, but can you please change the limits for 6dof arm as well?

Thank you

felixmaisonneuve commented 1 year ago

I will deny this pulll request, changes were added in #294

Thank you, Felix