[X] I have updated the title without removing the 🚧 emoji.
Description
Currently, the translation between the custom action glob matching syntax and regex syntax has an issue.
feature/setup-build-project
Value: feature/setup-build-project
Pattern: feature/setup-*-project
This was discovered when using the same code while playing around with Nuke build system framework.
Possible Solution:
The problems are that the globbing pattern needs to always start with a '^' symbol and end with a '$' symbol.
This could possibly just be fixed by improving the regex used. Attempt this solution first.
Also, the RegexOptions.IgnoreCase needs to NOT be used at all. Currently, if the value above had a 'Tfor the wordproject` ad the end, it would still pass. Remove case sensitivity.
Remove the MatchType. enum and its use case as well
Acceptance Criteria
[ ] The symbol '^' added to the start of the globbingPattern every time in the Match() method
[ ] The symbol '$' added to the end of the globbingPattern every time in the Match() method
[ ] Remove the RegexOptions.IgnoreCase argument for all RegEx.Match() method calls
ToDo Items
[X] Change type labels added to this issue. Refer to the Change Type Labels section below.
[X] Priority label added to this issue. Refer to the Priority Type Labels section below.
[X] Issue linked to the correct project (if applicable).
[X] Issue linked to the correct milestone (if applicable).
[ ] Draft pull request created and linked to this issue (only required with code changes).
Issue Dependencies
No response
Related Work
No response
Additional Information:
Change Type Labels
Change Type
Label
Bug Fixes
🐛bug
Breaking Changes
🧨breaking changes
New Feature
✨new feature
Workflow Changes
workflow
Code Doc Changes
🗒️documentation/code
Product Doc Changes
📝documentation/product
Priority Type Labels
Priority Type
Label
Low Priority
low priority
Medium Priority
medium priority
High Priority
high priority
Code of Conduct
[X] I agree to follow this project's Code of Conduct.
Complete The Item Below
Description
Currently, the translation between the custom action glob matching syntax and regex syntax has an issue.
feature/setup-build-project
This was discovered when using the same code while playing around with Nuke build system framework.
Possible Solution:
Also, the
RegexOptions.IgnoreCaseneeds to NOT be used at all. Currently, if the value above had a 'Tfor the wordproject` ad the end, it would still pass. Remove case sensitivity.Remove the
MatchType.enum and its use case as wellAcceptance Criteria
globbingPatternevery time in theMatch()methodglobbingPatternevery time in theMatch()methodRegexOptions.IgnoreCaseargument for allRegEx.Match()method callsToDo Items
Issue Dependencies
No response
Related Work
No response
Additional Information:
Change Type Labels
🐛bug🧨breaking changes✨new featureworkflow🗒️documentation/code📝documentation/productPriority Type Labels
low prioritymedium priorityhigh priorityCode of Conduct