KinsonDigital / Velaptor

2D game development framework
https://docs.velaptor.io
MIT License
70 stars 16 forks source link

🚧Change CornerRadius param order #966

Closed CalvinWilkinson closed 1 week ago

CalvinWilkinson commented 3 months ago

Complete The Item Below

Description

Change the order of the parameters for the constructor for the CornerRadius struct.

Currently, the parameters set the radius of each corner in a counter-clockwise order. This is not as intuitive. Most people naturally gravitate towards clockwise order.

Current Order:

  1. TopLeft
  2. BottomLeft
  3. BottomRight
  4. TopRight

Change To:

  1. TopLeft
  2. TopRight
  3. BottomRight
  4. BottomLeft

Also, verify that all other uses of struct internally within Velaptor take this into account so we avoid any bugs.

Acceptance Criteria

### The items to complete to satisfy the Definition of Done.
- [ ] All unit tests executed and passed locally after PR work is complete. _(Why? Refer to 'Additional Information' below.)_
- [ ] Struct parameter order changed
- [ ] All references and uses pdated internally
- [ ] All testing scenes related to rectangles updated

ToDo Items

### The items to complete to satisfy the Definition of Done.
- [x] Change type labels added to this issue.  Refer to the _**Change Type Labels**_ section below.
- [x] Priority label added to this issue.  Refer to the _**Priority Type Labels**_ section below.
- [x] Issue linked to the correct milestone _(if applicable)_.

Issue Dependencies

No response

Related Work

No response

Additional Information:

Unit Tests

Reasons for local unit test execution:

  • Unit tests might pass locally but not in the CI environment during the status check process or vice-versa.
  • Tests might pass on the developer's machine but not necessarily on the code reviewer's machine.
  • If you notice that the test status check has passed but the test failed locally, please notify a project maintainer!

💡Warning💡 If the unit tests pass remotely and are not executed locally, this means we could be letting a bug slip into production. Though bugs will always exist in some capacity, we should all do our part to help prevent them from happening.

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking changes
New Feature ✨new feature
CICD Changes ♻️cicd
Config Changes ⚙️config
Performance Improvements 🏎️performance
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct