CalvinWilkinson
commented
1 month ago @Hendrin-Mckay
Awesome!! Appreciate your time. 😉
One thing that I would do if you do mind is to check out the Contribution Guide.
This and the other markdown docs talk about how to contribute.
For example, I have some sophisticated CICD set up and it requires that the branch name be a certain name.
Also, every pull request needs to have an issue. I think the better way to go is to either submit a bug using the issue templates.
If you could please recreate the pull request with the correct branch following the feature branch syntax, that would be greatly appreciated. Once that is done, I will link up issue #692 the to pull request and we can move forward.
Example Branch: feature/123-my-branch.
Specifically, branching is here
If you have any questions or you see something that does not seem right, please don't hesitate to ask. 😊 I am also always available on the discord server.
Cheers!!
Modified a few files dealing with how font loading is done on platforms besides Windows and tried to avoid too much repeating code.
I am still a beginner at both C# and GIT so please review this, I tried testing it on Windows 11/Linux/OSX to make sure I didn't break anything in the process.
Linux appears to work with one issue (you need to resize the Window before it starts rendering anything). OSX (on Apple Silicon) has other issues as your using some stuff that requires OpenGL features beyond 4.1, which is the maximum supported on Apple Silicon (they expect you to support Metal or Metal via MoltenVK(Metal via Vulkan).
Plan to work on these issues but will do it on a separate request as they are completely different issues than what this one dealt with.