search

KintabaHQ / EtherKit

Apache License 2.0
42 stars 6 forks source link

callbacks never called #17

Open pteasima opened 6 years ago

pteasima commented 6 years ago

steps to reproduce: make a failed URL request using etherKit, e.g. give it a url that isnt running a node

expected: callback is called with the Result containing .failure(theNetworkingError)

actual: callback is never called https://github.com/Vaultio/EtherKit/blob/master/EtherKit/RequestProtocols/URLRequestManager.swift line 35 just returns.

notes: I found another place where this can theoretically happen https://github.com/Vaultio/EtherKit/blob/master/EtherKit/RequestProtocols/RequestManager.swift line 45 , there may be others

pr0zac commented 6 years ago

Acknowledged! Thanks @pteasima!