KintabaHQ / EtherKit

Apache License 2.0
42 stars 6 forks source link

There were issues with protocol witness table linking during archivi… #2

Closed SirensOfTitan closed 6 years ago

SirensOfTitan commented 6 years ago

…ng for Vault, so I fixed it by making the UnformattedDataType public.

I would prefer for the UnformattedDataType.init(data:) to remain non-public, it doesn't do validation that the data matches the byte requirements, and it's difficult to do so as data is a stored property on structs that implement UnformattedDataType. I'm sure there's a way to pull this off without resulting in use of associated objects (which would require a movement to use classes to force compatibility with NSObject), but I'm not sure how right now.