search

Kinto / kinto-admin

Kinto Web Administration Console
http://kinto.github.io/kinto-admin/
185 stars 35 forks source link

Should we pin against a specific Node version? #1222

Open glasserc opened 4 years ago

glasserc commented 4 years ago

https://github.com/nodejs/node/commit/3e0709cf5e landed in Node v10.8.1. We pin to Node v10 but not with any more specificity than that. This broke a test. The fix is easy but it raises the question of whether we should pin the Node version more tightly so that these changes are at least made explicit.

My personal opinion could go either way on this. It was a minor, cosmetic feature that broke and the tests caught it. On the other hand, we do have control over what version of Node we are using and we could justifiably pin the CI to whatever we use in prod.

alexcottner commented 1 month ago

We've moved to 16+ at this point. Given that this issue hasn't come up again, I'm not sure if we want to dedicate more time to thinking about it.