search

Kinto / kinto-admin

Kinto Web Administration Console
http://kinto.github.io/kinto-admin/
184 stars 35 forks source link

Fixes #3202: allowing self review when `to_review_enabled` is false #3207

Closed alexcottner closed 2 months ago

alexcottner commented 3 months ago

Resolves #3202 - allowing for self review when to_review_enabled is false on either the signer plugin level or the specific resource mapping.

Added unit tests to simple-review and legacy review toolbar to ensure consistent behavior.

alexcottner commented 2 months ago

I think what you have now is correct. But I found the code hard to read/verify. Not blocking landing, but please consider taking it into account if my feedback makes sense

I did a a little refactor to make it more reasonable to test and read.