Add a new ``kinto.admin_assets_path`` to specify the location of the Admin UI assets

Kinto / kinto

A generic JSON document store with sharing and synchronisation capabilities.

http://docs.kinto-storage.org/

Other

4.32k stars 420 forks source link

Add a new ``kinto.admin_assets_path`` to specify the location of the Admin UI assets #3343

Closed leplatrem closed 7 months ago

leplatrem commented 7 months ago

[x] Add documentation.
[x] Add tests.
[x] Add a changelog entry.
[x] Add your name in the contributors file.
[x] If you changed the HTTP API, update the API_VERSION constant and add an API changelog entry in the docs
[x] If you added a new configuration setting, update the kinto.tpl file with it.

alexcottner commented 7 months ago

I did some testing locally and this appears to serve the index.html file from the set location, but still serves the bundle.js and style.css and other files from the included kinto-admin folder. Trying to investigate further.

alexcottner commented 7 months ago

I think we need to adjust this logic as well: https://github.com/Kinto/kinto/blob/introduce-admin-ui-location-setting/kinto/plugins/admin/__init__.py#L26-L28

leplatrem commented 7 months ago

Nice catch! I would have missed it