search

Kinto / kinto

A generic JSON document store with sharing and synchronisation capabilities.
http://docs.kinto-storage.org/
Other
4.32k stars 420 forks source link

Playwright #3374

Closed alexcottner closed 7 months ago

alexcottner commented 7 months ago

Fixes #3341 - Replacing selenium browser-test with playwright

This replaces the existing browser test with a very simple test that verifies we can login to the site and see the expected home page. We will add more detailed testing to the kinto-admin project.

I propose we make the same change in remote-settings, then start working on a comprehensive test suite in the kinto-admin project. Created https://github.com/Kinto/kinto-admin/issues/3147 as followup.

This was done in node in an attempt to keep our UI testing code consistent. However, if we prefer to do that in python (since this is a python project) I can change it pretty easily.

grahamalama commented 7 months ago

Nice! A step in the right direction.

Was there a reason you opted for the Javascript version of playwright instead of the Python version? It'd be nice to stick to one language in this repo

alexcottner commented 7 months ago

Was there a reason you opted for the Javascript version of playwright instead of the Python version? It'd be nice to stick to one language in this repo

I forgot to mention that in the PR body. I can change this to python pretty easily, my initial thought was keeping the testing framework/language consistent was slightly more beneficial. But I'm ~51/49 on that particular fence and it's not like the tests in here or remote-settings will be all that complex.

grahamalama commented 7 months ago

my initial thought was keeping the testing framework/language consistent

Here do you mean consistent across different repos? Like we'll be using Playwright here (a Python project) and Kinto Admin (a JS project), so it's better to have Playwright tests be consistently written than match the predominant language in a repo?

alexcottner commented 7 months ago

Here do you mean consistent across different repos?

Correct, I thought that having a consistent pattern there was slightly better than switching to fit the language of the project. I will hopefully have a python version up tomorrow for comparison. It'll still be pretty simple, just got sidetracked today.

leplatrem commented 7 months ago

Yes, I agree with Graham. I'm sorry for the lost energy, but for the convenience of contributors it would be better to spare the usage of npm