search

Kiougar / luci-wrtbwmon

Bandwidth tracker for OpenWRT that uses wrtbwmon
https://github.com/pyrovski/wrtbwmon
MIT License
327 stars 56 forks source link

Openwrt 18.06 bootstrap theme squished table #24

Closed shemgp closed 6 years ago

shemgp commented 6 years ago

The display of the usage table when running on OpenWRT 18.06 doesn't look nice as tables don't have styles anymore in the new bootstrap theme (looking at the css). tables

Kiougar commented 6 years ago

Hey @shemgp, thanks for reporting!

I noticed in the release notes of 18.06 this line:

A GUI bug prevents selecting and scrolling text in the system and kernel log pages. To solve, either upgrade "luci-theme-bootstrap" using opkg or switch to another theme. [fix merged, queued for 18.06.1]

Can you please upgrade "luci-theme-bootstrap" using opkg and see if the issue persists?

shemgp commented 6 years ago

I upgraded luci-theme-bootstrapalready and the tables display is still squished.

Looking at the loaded css in the page: there is no pretty styling for tables. That's probably because they wanted to use responsive tables so all tables are now divs, that's why they removed the table tag padding/styling.

erotavlasme commented 6 years ago

I can confirm the same behaviour with openWRT 18.06.1. What about releasing and official openWRT package?

Kiougar commented 6 years ago

Sorry for the late response - summer was kinda busy :)

I'll work on it the following week.

Kiougar commented 6 years ago

@erotavlas85, @shemgp I'm currently working on the fix. Doing some cleanup as well.

Expect this to be closed in the coming days with the new release.

Thanks for reporting!

erotavlasme commented 6 years ago

Great. Are you planning to release the software into the official repository?

Kiougar commented 6 years ago

Yes! Do you have any insights on how should I do it? Never done this before :)

erotavlasme commented 6 years ago

I never did before, but the documentation seems straightforward.