style: decoupling `kipdb::TransactionIter` - Githubissues

KipData / FnckSQL

SQL as a Function for Rust

Apache License 2.0

567 stars 48 forks source link

style: decoupling `kipdb::TransactionIter` #198

Closed KKould closed 8 months ago

KKould commented 8 months ago

What problem does this PR solve?

I tried to use redb as the new storage engine. Although it failed, it removed the coupling of kipdb.

Code changes

[x] Has Rust code change
[ ] Has CI related scripts change

Check List

Tests

[x] Unit test
[x] Integration test
[x] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Note for reviewer

KKould commented 8 months ago

oh, there are so many default implements in Transaction

yep, to avoid code duplication when supporting new storage engines