search

KipK / openevse-gui-v2

OpenEVSE WiFi Gateway User Interface (V2)
BSD 2-Clause "Simplified" License
5 stars 2 forks source link

Firmware update dialog release, pre-release, and dev build confusion #40

Open fhteagle opened 1 year ago

fhteagle commented 1 year ago

With 4.1.9 installed, the presence of the 4.1.7 in green and "Update" button make it look like the user should be "upgrading" to a lower software version. I have not actually clicked update to see what the actual results are.

Screenshot_20230330_082419

Or is this a symptom of https://github.com/OpenEVSE/ESP32_WiFi_V4.x/issues/584 ?

KipK commented 1 year ago

4.1.9 is still prerelease

KipK commented 1 year ago

You should stay on dev build for now pre release build still has few problems

fhteagle commented 1 year ago

Okay, it is getting a little hard for the testing public to follow what branch/version/from what repo/google drive drop should be tested when. Seems like others are having trouble as well, as indicated by the tail end of this thread: https://community.openenergymonitor.org/t/openevse-new-user-interface-testers-translations-needed/22371/

Can we rethink the strategy of having the wifi firmware and GUI codebases in separate repos? Seems like they are not staying sync'ed and one is always ahead in some ways and behind the other in some ways....

KipK commented 1 year ago

This because some PR takes time to be merged and so fixes are sometime just on my personal builds for testing .

This will change after next major release when the UI2 will be considered as official. We are still in a kind of transition , and as you followed there was lot of stuff to fix on different fronts

fhteagle commented 1 year ago

So to take this one step further:

I have the OTA updated dev build master_764b3174_modified on one of my units. If I go to Config > Firmware > Update > Check "Dev", I see "V2 GUI pre-release 2023-05-10T05:28:39Z" is current.

A. That commit id does not match either the "Development Build", nor the "V2 GUI Pre-Release" from https://github.com/OpenEVSE/ESP32_WiFi_V4.x/releases . Is the Update dialog not actually pulling the latest from here? B. There is nothing in the version string of currently installed, or the string of available OTA that tells me if what I have is current or not. Therefore, I have to try to remember what I last installed and if it matches or is older than the available dev OTA.

Possible solutions:

  1. Mod the build string to include a date string, such as master_764b3174_202305100528
  2. Change the available OTA display to include the commit id instead of "V2 GUI ..."
  3. Show the installed firmware's release datetime value on the update dialog?

Not sure what is easiest based on the github tags / json manifest / etc that @KipK and @jeremypoulter cooked up. Just looking for something I do not have to remember to be able to determine if I have the latest dev release or not.

I do not think greying out or disabling the Update button is a good solution, as it might be useful to reinstall the current OTA in case of a bad flash event?

KipK commented 1 year ago

this has changed after the 4.2.2 release, it was in development stage. There's no v2 gui anymore, in the dev tree, gui has been merged now. Dev builds will still keep github short hash as version number however.