KipK / openevse-gui-v2

OpenEVSE WiFi Gateway User Interface (V2)
BSD 2-Clause "Simplified" License
5 stars 2 forks source link

todo: add some check to prevent OTA on _dev debug builds #41

Open KipK opened 1 year ago

KipK commented 1 year ago

https://community.openenergymonitor.org/t/openevse-new-user-interface-testers-translations-needed/22371/250?u=guillaume_s

jeremypoulter commented 1 year ago

I have been thinking about the issues you have been having with the updates, would it help to upload a json file with info about the releases? If so what information would you like in the file?

KipK commented 1 year ago

Why not. What's GitHub is giving through the api seems enough, just need to fill one unused field with the release number/hash. Doing it with our own Json would probably simplify the thing.

KipK commented 1 year ago

@jeremypoulter something like this generated for each build could be good enough:

{
    tag: "v2_gui" 
    name: "V2 GUI pre-release"
    version: "latest-1-g1fcd5d8"
    type: "daily" //( release , pre-release, daily )
    date: "2023-04-01T23:39:38Z",
    files: [
        {
        build: "openevse_wifi_v1"},
        url: "http://..../openevse_wifi_v1.bin"
        }

    ]
}
{
    tag: "v4.2.0" 
    name: "V.4.2.0"
    version: "v4.2.0"
    type: "prerelease" //( release , prerelease, daily )
    date: "2023-04-01T23:39:38Z",
    files: [
        {
        build: "openevse_wifi_v1"},
        url: "http://..../openevse_wifi_v1.bin"
        }

    ]
}
KipK commented 1 year ago

But if you find a way to add the version for all types directly on github api /release feed, then we don't need external file.

( the get the "latest-1-g1fcd5d8" for the dailies, for now grabing the tag_name or name gives "v2_gui" or "V2 GUI pre-release" )

image

jeremypoulter commented 1 year ago

Will take a look, might not be able to do the release/pre-release but will see. FYI I have changed the version format on the latest master as git describe is not consistent

KipK commented 1 year ago

For release / prerelase the tag_name field is ok, for dailies we'll have to use something else