search

Kipjr / cookieconsent

Simple cookie consent for Piwigo
https://piwigo.org/ext/extension_view.php?eid=888
3 stars 3 forks source link

Since PHP 7.3.0 able to set sameSite cookie value #8

Closed 7tonin closed 3 years ago

7tonin commented 3 years ago

Before PHP 7.3.0, a sameSite cookie default value is used by the browser. Will browsers behave as expected ?

7tonin commented 3 years ago

Not an issue (Check paragraph before the first note: https://www.php.net/manual/en/language.types.array.php) This setcookie syntax is useful because it brings sameSite option, which looks to be required in a while... (I have just seen a little warning in my browser console)

But what to do for PHP < 7.3.0 since piwigo is supported for PHP >= 5.3? Do you plan to use this https://www.php.net/manual/en/function.version-compare

Kipjr commented 3 years ago

Yes I will use this but I need a bit more free time to implement and check everything. I will accept the merge request ;) Thanks for your contribution!